Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add validate APIs #189

Merged
merged 1 commit into from
Nov 29, 2023
Merged

feat: add validate APIs #189

merged 1 commit into from
Nov 29, 2023

Conversation

Peefy
Copy link
Contributor

@Peefy Peefy commented Nov 27, 2023

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y
  • feat: add validate APIs

2. What is the scope of this PR (e.g. component or file name):

  • kclvm.go
  • pkg/tools/validate/validate.go

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other
  • pkg/tools/validate/validate_test.go

@Peefy Peefy changed the title feat: add validate APIs [WIP] feat: add validate APIs Nov 27, 2023
@Peefy Peefy added the api label Nov 28, 2023
@Peefy Peefy changed the title [WIP] feat: add validate APIs feat: add validate APIs Nov 29, 2023
@coveralls
Copy link

Pull Request Test Coverage Report for Build 7033146558

  • 20 of 29 (68.97%) changed or added relevant lines in 2 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.07%) to 63.086%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/tools/validate/validate.go 20 24 83.33%
kclvm.go 0 5 0.0%
Files with Coverage Reduction New Missed Lines %
kclvm.go 1 70.83%
Totals Coverage Status
Change from base Build 7033057289: 0.07%
Covered Lines: 2707
Relevant Lines: 4291

💛 - Coveralls

@Peefy Peefy merged commit 83897a5 into kcl-lang:main Nov 29, 2023
7 checks passed
@Peefy Peefy deleted the validate-api branch November 29, 2023 13:23
@github-actions github-actions bot locked and limited conversation to collaborators Nov 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

support Go API for GetSchemaTypeMapping
2 participants